Bug 101405

Summary: [CSS Exclusions] Changeset r133384 defeated the rectilinear polygon tests
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2012-11-06 15:51:36 PST
The patch from https://bugs.webkit.org/show_bug.cgi?id=100704, changeset r133384, failed to refactor the two rectilinear polygon tests: shape-inside-rectilinear-polygon-001.html and shape-inside-rectilinear-polygon-002.html. Both tests must now include the subpixel-utils.js. Currently both the tests and their expected HTML throw the same JS exception, so the reftests appear to "pass".
Attachments
Patch (3.47 KB, patch)
2012-11-06 16:01 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2012-11-06 16:01:29 PST
Created attachment 172668 [details] Patch Corrected the tests.
Dirk Schulze
Comment 2 2012-11-06 16:10:20 PST
Comment on attachment 172668 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-11-06 17:02:42 PST
Comment on attachment 172668 [details] Patch Clearing flags on attachment: 172668 Committed r133697: <http://trac.webkit.org/changeset/133697>
WebKit Review Bot
Comment 4 2012-11-06 17:02:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.