Bug 101386

Summary: [BlackBerry] Pushing window.external.* events to webplatform
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

otcheung
Reported 2012-11-06 13:14:18 PST
The stubs for window.external are in place. Add event calls so we can handle the event on the browser chrome.
Attachments
Patch (3.40 KB, patch)
2012-11-06 13:19 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2012-11-06 13:27 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-11-06 13:19:49 PST
Created attachment 172636 [details] Patch
Rob Buis
Comment 2 2012-11-06 13:25:47 PST
Comment on attachment 172636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172636&action=review Small fixies to do. > Source/WebKit/blackberry/ChangeLog:8 > + Adding calls to trigger window.external events so we could handle them on the we could -> we can. Yes we can! > Source/WebKit/blackberry/Api/WebPageClient.h:266 > + virtual int isSearchProviderInstalled(const Platform::String& newURL) = 0; newURL can be left off here.
otcheung
Comment 3 2012-11-06 13:27:24 PST
Created attachment 172638 [details] Patch
Rob Buis
Comment 4 2012-11-06 13:28:21 PST
Comment on attachment 172638 [details] Patch LGTM.
WebKit Review Bot
Comment 5 2012-11-06 14:00:50 PST
Comment on attachment 172638 [details] Patch Clearing flags on attachment: 172638 Committed r133667: <http://trac.webkit.org/changeset/133667>
WebKit Review Bot
Comment 6 2012-11-06 14:00:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.