Summary: | [BlackBerry] Pushing window.external.* events to webplatform | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | otcheung | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
otcheung
2012-11-06 13:14:18 PST
Created attachment 172636 [details]
Patch
Comment on attachment 172636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172636&action=review Small fixies to do. > Source/WebKit/blackberry/ChangeLog:8 > + Adding calls to trigger window.external events so we could handle them on the we could -> we can. Yes we can! > Source/WebKit/blackberry/Api/WebPageClient.h:266 > + virtual int isSearchProviderInstalled(const Platform::String& newURL) = 0; newURL can be left off here. Created attachment 172638 [details]
Patch
Comment on attachment 172638 [details]
Patch
LGTM.
Comment on attachment 172638 [details] Patch Clearing flags on attachment: 172638 Committed r133667: <http://trac.webkit.org/changeset/133667> All reviewed patches have been landed. Closing bug. |