Bug 101375

Summary: Some cookie code cleanup
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: PlatformAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, jberlin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
mitz: review+
patch for landing none

Alexey Proskuryakov
Reported 2012-11-06 10:59:31 PST
Doing it in small steps.
Attachments
proposed patch (9.31 KB, patch)
2012-11-06 11:08 PST, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
patch for landing (9.31 KB, patch)
2012-11-06 12:37 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-11-06 11:08:24 PST
Created attachment 172621 [details] proposed patch
mitz
Comment 2 2012-11-06 11:15:06 PST
Comment on attachment 172621 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172621&action=review > Source/WebCore/ChangeLog:13 > + (WebCore): Removed special code for isHTTPOnly, it's present Foundation in all Typo: “present Foundation” > Source/WebCore/ChangeLog:19 > + Set-Cookie header, document.cookie can only be used to saet one cookie at a time. Typo: “saet” > Source/WebCore/platform/CookieJar.h:40 > +// These two methods implement document.cookie API, with special rules for HttpOnly cookies. “(member) functions” rather than “methods”?
Alexey Proskuryakov
Comment 3 2012-11-06 12:37:24 PST
Created attachment 172631 [details] patch for landing
WebKit Review Bot
Comment 4 2012-11-06 13:25:04 PST
Comment on attachment 172631 [details] patch for landing Clearing flags on attachment: 172631 Committed r133664: <http://trac.webkit.org/changeset/133664>
Note You need to log in before you can comment on or make changes to this bug.