Bug 101367 – check-webkit-style false report about asm() code in DFGOperations.cpp.

• Component: Tools / Tests
• Status: UNCONFIRMED

[Balazs Kilvady]

As I didn't find coding style rules to asm(…) blocks just followed the style/indention of existing asm(… ) blocks but received:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.cpp:1569:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]

for:

asm(
".text" "\n"
".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
HIDE_SYMBOL(getHostCallReturnValue) "\n"
SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
    LOAD_FUNCTION_TO_T9(getHostCallReturnValueWithExecState)
    "lw $s0, -40($s0)" "\n"
    "move $a0, $s0" "\n"
    "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"
);

Where line 1569 is the closing );

[Balazs Kilvady]

Created attachment 173060 [details]
patch

With this patch "asm(" "asm (" "__asm(" and "__asm (" blocks accepted at style checking.

[Simon Hausmann]

Comment on attachment 173060 [details]
patch

Would it make sense perhaps to also add a unit test for this in cpp_unittest.py?

[Anders Carlsson]

Comment on attachment 173060 [details]
patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.