Bug 101363

Summary: Web Inspector: Infinite loop in DataGrid::autoSizeColumn
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Vsevolod Vlasov
Reported 2012-11-06 09:24:19 PST
Patch to follow.
Attachments
Patch (1.98 KB, patch)
2012-11-06 09:25 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (9.58 KB, patch)
2012-11-07 06:47 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (9.69 KB, patch)
2012-11-07 06:55 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (9.69 KB, patch)
2012-11-07 08:36 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-11-06 09:25:12 PST
Created attachment 172603 [details] Patch
Pavel Feldman
Comment 2 2012-11-07 05:48:13 PST
Comment on attachment 172603 [details] Patch A test?
Vsevolod Vlasov
Comment 4 2012-11-07 06:47:53 PST
Created attachment 172787 [details] Patch
Vsevolod Vlasov
Comment 5 2012-11-07 06:55:59 PST
Created attachment 172789 [details] Patch
Build Bot
Comment 6 2012-11-07 08:11:08 PST
Comment on attachment 172789 [details] Patch Attachment 172789 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14757413 New failing tests: inspector/storage-panel-dom-storage.html inspector/console/command-line-api-inspect.html inspector/storage-panel-dom-storage-update.html
WebKit Review Bot
Comment 7 2012-11-07 08:15:33 PST
Comment on attachment 172789 [details] Patch Attachment 172789 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14759391 New failing tests: inspector/storage-panel-dom-storage.html inspector/console/command-line-api-inspect.html inspector/storage-panel-dom-storage-update.html
Vsevolod Vlasov
Comment 8 2012-11-07 08:36:54 PST
Created attachment 172816 [details] Patch
WebKit Review Bot
Comment 9 2012-11-07 22:45:31 PST
Comment on attachment 172816 [details] Patch Clearing flags on attachment: 172816 Committed r133851: <http://trac.webkit.org/changeset/133851>
WebKit Review Bot
Comment 10 2012-11-07 22:45:34 PST
All reviewed patches have been landed. Closing bug.
eustas.bug
Comment 11 2012-11-08 01:58:23 PST
Comment on attachment 172816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172816&action=review > Source/WebCore/inspector/front-end/DataGrid.js:439 > + * @param {Array<number>} widths You've missed "." between "Array" and "<number>"
Vsevolod Vlasov
Comment 12 2012-11-08 03:49:42 PST
(In reply to comment #11) > (From update of attachment 172816 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172816&action=review > > > Source/WebCore/inspector/front-end/DataGrid.js:439 > > + * @param {Array<number>} widths > > You've missed "." between "Array" and "<number>" Thank you, fixed.
Note You need to log in before you can comment on or make changes to this bug.