Bug 101329 – [Chromium-win] Refactor date/time format conversion code in LocaleWin

• Component: Platform
• Status: RESOLVED FIXED

[Kent Tamura]

[Chromium-win] Refactor date/time format parsing code in LocaleWin

[Kent Tamura]

Created attachment 172535 [details]
Patch

[Kentaro Hara]

Comment on attachment 172535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172535&action=review

> Source/WebCore/platform/text/win/LocaleWin.cpp:242
> +                else
> +                    converted.append("EEEE");

'ddddd' is converted to 'EEEE'. Is it expected?

> Source/WebCore/platform/text/win/LocaleWin.cpp:251
> +            } else if (ch == 't')
> +                converted.append('a');

't' and 'tt' are converted to 'a', which looks ok. 'ttt' is also converted to 'a', is it expected?

[Kent Tamura]

Comment on attachment 172535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172535&action=review

>> Source/WebCore/platform/text/win/LocaleWin.cpp:242
>> +                    converted.append("EEEE");
> 
> 'ddddd' is converted to 'EEEE'. Is it expected?

Yes.
ddddd is invalid according to MSDN, and users can't set arbitrary format in Control Panel. ddddd should not appear unless OS is corrupted, and any behavior would be ok here.

>> Source/WebCore/platform/text/win/LocaleWin.cpp:251
>> +                converted.append('a');
> 
> 't' and 'tt' are converted to 'a', which looks ok. 'ttt' is also converted to 'a', is it expected?

Ditto.

[Kentaro Hara]

Comment on attachment 172535 [details]
Patch

Makes sense. Thanks for the clarification.

[WebKit Review Bot]

Comment on attachment 172535 [details]
Patch

Clearing flags on attachment: 172535

Committed r133712: <http://trac.webkit.org/changeset/133712>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 101461

[Kent Tamura]

(In reply to comment #7)
> Re-opened since this is blocked by bug 101461

Oh, XP-only failures.  I found my change unveiled a bug in the XP/Vista-only path of LocaleWin::shortTimeFormat, which converts a format twice.

[Kent Tamura]

Committed r133842: <http://trac.webkit.org/changeset/133842>