Bug 101323

Summary:

[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

WebKit EFL

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, gyuyoung.kim, lucas.de.marchi, mrobinson, tonikitoo, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Bumping version, removing ifdef.	none
Patch	none
Patch v2. Against harfbuzz 0.9.6 release.	none

Dominik Röttsches (drott)

Reported 2012-11-06 01:33:38 PST

Bug 101009 has a fix ifdef'ed for Chromium due to a difference in HarfBuzz versions, let's bump.

Attachments
Bumping version, removing ifdef. (4.49 KB, patch) 2012-11-06 06:20 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch (6.74 KB, patch) 2012-11-07 08:13 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch v2. Against harfbuzz 0.9.6 release. (6.24 KB, patch) 2012-11-15 05:10 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dominik Röttsches (drott)

Comment 1 2012-11-06 04:42:33 PST

Problematic issue with harfbuzz not finding ICU, as Martin Robinson mentions: https://bugs.webkit.org/show_bug.cgi?id=92098#c13 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687339

Dominik Röttsches (drott)

Comment 2 2012-11-06 04:49:36 PST

Ubuntu Bug https://bugs.launchpad.net/ubuntu/+source/icu/+bug/1037588

Dominik Röttsches (drott)

Comment 3 2012-11-06 06:12:10 PST

Waiting for Harfbuzz to merge the build fix proposal: http://lists.freedesktop.org/archives/harfbuzz/2012-November/002612.html

Dominik Röttsches (drott)

Comment 4 2012-11-06 06:20:13 PST

Created attachment 172569 [details] Bumping version, removing ifdef.

Dominik Röttsches (drott)

Comment 5 2012-11-06 06:22:23 PST

(In reply to comment #4) > Created an attachment (id=172569) [details] > Bumping version, removing ifdef. The exact hash needs to be updated once Behdad would merge my buildfix proposal.

EFL EWS Bot

Comment 6 2012-11-06 07:56:38 PST

Comment on attachment 172569 [details] Bumping version, removing ifdef. Attachment 172569 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14731763

Dominik Röttsches (drott)

Comment 7 2012-11-07 08:13:36 PST

Created attachment 172807 [details] Patch

Martin Robinson

Comment 8 2012-11-07 08:44:10 PST

Wouldn't it be better just to wait for 0.9.6?

EFL EWS Bot

Comment 9 2012-11-07 08:57:41 PST

Comment on attachment 172807 [details] Patch Attachment 172807 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14755511

Dominik Röttsches (drott)

Comment 10 2012-11-15 05:10:53 PST

Created attachment 174410 [details] Patch v2. Against harfbuzz 0.9.6 release.

Dominik Röttsches (drott)

Comment 11 2012-11-15 05:13:03 PST

(In reply to comment #8) > Wouldn't it be better just to wait for 0.9.6? Unfortunately, my build fix was not important enough to be merged into 0.9.6. :-(

Martin Robinson

Comment 12 2012-11-15 08:30:18 PST

Comment on attachment 174410 [details] Patch v2. Against harfbuzz 0.9.6 release. Great work. Thanks!

WebKit Review Bot

Comment 13 2012-11-15 09:00:02 PST

Comment on attachment 174410 [details] Patch v2. Against harfbuzz 0.9.6 release. Clearing flags on attachment: 174410 Committed r134781: <http://trac.webkit.org/changeset/134781>

WebKit Review Bot

Comment 14 2012-11-15 09:00:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.