Bug 101319

Summary: ScriptWrappable should work for more than just Node
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, eric, ggaren, haraken, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101279    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-11-06 01:07:14 PST
ScriptWrappable should work for more than just Node
Attachments
Patch (4.99 KB, patch)
2012-11-06 01:08 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-11-06 01:08:50 PST
Created attachment 172510 [details] Patch
Eric Seidel (no email)
Comment 2 2012-11-06 01:21:35 PST
Comment on attachment 172510 [details] Patch LGTM. Mostly just moving code. YOu may want ggaren, olliej, gavin, etc. to look before you land -- their JSC knowledge is much fresher than mine.
Kentaro Hara
Comment 3 2012-11-06 01:23:03 PST
Comment on attachment 172510 [details] Patch LGTM too.
Adam Barth
Comment 4 2012-11-06 07:33:55 PST
@ggaren: Would you like to take a look before I land this patch? This is related to http://lists.webkit.org/pipermail/webkit-dev/2012-November/022737.html
Adam Barth
Comment 5 2012-11-06 09:45:50 PST
Comment on attachment 172510 [details] Patch This patch combined with the patch in bug 101279 is a 69% improvement for JSC in the performance of document.implementation. I'd like to move forward with these patches. ggaren, if you have feedback, I'm happy to address it in a followup patch.
WebKit Review Bot
Comment 6 2012-11-06 10:20:14 PST
Comment on attachment 172510 [details] Patch Clearing flags on attachment: 172510 Committed r133633: <http://trac.webkit.org/changeset/133633>
WebKit Review Bot
Comment 7 2012-11-06 10:20:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.