Bug 101313

Summary: Indentation of JSObject.h is wrong
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ap: review+

Filip Pizlo
Reported 2012-11-05 23:53:52 PST
We don't indent inside namespaces.
Attachments
the patch (66.82 KB, patch)
2012-11-05 23:57 PST, Filip Pizlo 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-05 23:57:17 PST
Created attachment 172495 [details] the patch
WebKit Review Bot
Comment 2 2012-11-06 00:02:43 PST
Attachment 172495 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSObject.h:80: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSObject.h:81: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSObject.h:82: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSObject.h:83: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSObject.h:84: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSObject.h:542: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/JSObject.h:777: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2012-11-06 10:08:41 PST
Comment on attachment 172495 [details] the patch rs=me, assuming that this was a single Cmd+[ (or equivalent).
Filip Pizlo
Comment 4 2012-11-06 11:15:30 PST
(In reply to comment #3) > (From update of attachment 172495 [details]) > rs=me, assuming that this was a single Cmd+[ (or equivalent). Indeed it was. Thanks!
Filip Pizlo
Comment 5 2012-11-06 11:19:53 PST
Landed in http://trac.webkit.org/changeset/133649
Note You need to log in before you can comment on or make changes to this bug.