Bug 101276

Summary: Prototype chain caching should check that the path from the base object to the slot base involves prototype hops only
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 101147    
Attachments:
Description Flags
the patch barraclough: review+

Filip Pizlo
Reported 2012-11-05 16:32:57 PST
Patch forthcoming.
Attachments
the patch (25.27 KB, patch)
2012-11-05 16:36 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-05 16:36:40 PST
Created attachment 172435 [details] the patch
Gavin Barraclough
Comment 2 2012-11-05 17:15:40 PST
Comment on attachment 172435 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=172435&action=review > Source/JavaScriptCore/runtime/Operations.h:309 > + if (cell->inherits(&JSProxy::s_info)) You could use isProxy here if you like.
Filip Pizlo
Comment 3 2012-11-05 17:52:22 PST
(In reply to comment #2) > (From update of attachment 172435 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172435&action=review > > > Source/JavaScriptCore/runtime/Operations.h:309 > > + if (cell->inherits(&JSProxy::s_info)) > > You could use isProxy here if you like. Good point. I changed it to use isProxy(), and moved isProxy() to JSCell as per our discussions.
Filip Pizlo
Comment 4 2012-11-05 17:54:03 PST
Landed in http://trac.webkit.org/changeset/133546
Note You need to log in before you can comment on or make changes to this bug.