Bug 101147 – Get rid of method_check

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

After https://bugs.webkit.org/show_bug.cgi?id=101146 is done, there should not be any reason left for using method_check.

[Filip Pizlo]

This depends on https://bugs.webkit.org/show_bug.cgi?id=101146 because the one thing that method_check currently gives, that get_by_id proto & chain caching did not give us, is detection of a prototype having things added to it without otherwise changing the prototype chain.  method_check will silently repatch itself in those situations without adding to the chain list.

However, once https://bugs.webkit.org/show_bug.cgi?id=101146 lands, proto & chain caching will have this behavior as well, since the cache lists will be cleared when a prototype has things added to it.

[Filip Pizlo]

Created attachment 172278 [details]
the patch

[WebKit Review Bot]

Attachment 172278 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/JIT.h:524:  The parameter name "ident" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JIT.h:524:  The parameter name "iter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JIT.h:600:  The parameter name "ident" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JIT.h:600:  The parameter name "iter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[kov's GTK+ EWS bot]

Comment on attachment 172278 [details]
the patch

Attachment 172278 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14712936

[Early Warning System Bot]

Comment on attachment 172278 [details]
the patch

Attachment 172278 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14717736

[Early Warning System Bot]

Comment on attachment 172278 [details]
the patch

Attachment 172278 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14690200

[EFL EWS Bot]

Comment on attachment 172278 [details]
the patch

Attachment 172278 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14714723

[Filip Pizlo]

Created attachment 172281 [details]
the patch

Fix style and non-Mac builds.

[Build Bot]

Comment on attachment 172281 [details]
the patch

Attachment 172281 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14732530

New failing tests:
fast/js/toString-and-valueOf-override.html

[Geoffrey Garen]

Comment on attachment 172281 [details]
the patch

r=me

[Filip Pizlo]

(In reply to comment #9)
> (From update of attachment 172281 [details])
> Attachment 172281 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/14732530
> 
> New failing tests:
> fast/js/toString-and-valueOf-override.html

Turns out this was a preexisting bug in get_by_id.  Fixed by https://bugs.webkit.org/show_bug.cgi?id=101276.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/133564