Bug 101275

Summary: Clean up ScrollingConstraints.h
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, darin, jamesr, simon.fraser, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Beth Dakin
Reported 2012-11-05 16:28:04 PST
Darin suggested a few small clean-ups to ScrollingConstraints.h here: https://bugs.webkit.org/show_bug.cgi?id=100796#c3 This bug tracks making the changes he suggested.
Attachments
Patch (3.22 KB, patch)
2012-11-05 16:30 PST, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-11-05 16:30:46 PST
Created attachment 172434 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-11-05 16:37:48 PST
Comment on attachment 172434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review > Source/WebCore/page/scrolling/ScrollingConstraints.h:-65 > - ViewportConstraints() > - : m_anchorEdges(0) > - { } You need this one to initialize m_anchorEdges, no?
Beth Dakin
Comment 3 2012-11-05 16:48:54 PST
(In reply to comment #2) > (From update of attachment 172434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review > > > Source/WebCore/page/scrolling/ScrollingConstraints.h:-65 > > - ViewportConstraints() > > - : m_anchorEdges(0) > > - { } > > You need this one to initialize m_anchorEdges, no? Oops, yes! Thank you! http://trac.webkit.org/changeset/133542
Note You need to log in before you can comment on or make changes to this bug.