Summary: | [Qt4] QtWebKit-2.3 tries to open non-existent qopengl.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cedric Hombourger <chombourger> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | allan.jensen, dino, noam, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 88186 | ||||||||
Attachments: |
|
Description
Cedric Hombourger
2012-11-05 13:27:03 PST
Created attachment 172399 [details]
proposed patch
Attachment 172399 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 172404 [details]
proposed patch
Does it also work if you include qgl.h instead of qopengl.h ? Comment on attachment 172404 [details]
proposed patch
Qt4 specific changes are no longer commited to trunk, but I will apply it on QtWebKit2.3
Commited as 93525bce7330e0b56f186140b6a053a4f3dbf9a4 and pushed in qtwebkit-2.3-staging |