Bug 101223

Summary: [BlackBerry] ImageDiff build clean-up
Product: WebKit Reporter: Ming Xie <mxie>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, gyuyoung.kim, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rwlbuis: review-

Ming Xie
Reported 2012-11-05 08:05:08 PST
We should put the ImageDiff build artifacts into the build folder instead of leaving it in Tools/ Also rename the build script to buildImageDiff.sh
Attachments
Patch (4.00 KB, patch)
2012-11-05 08:25 PST, Ming Xie 		rwlbuis: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ming Xie
Comment 1 2012-11-05 08:25:38 PST
Created attachment 172338 [details] Patch
Rob Buis
Comment 2 2012-11-05 08:41:10 PST
Comment on attachment 172338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review Looks good, can be made a bit more robust. > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6 > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff" It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.
Ming Xie
Comment 3 2012-11-05 09:04:44 PST
(In reply to comment #2) > (From update of attachment 172338 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review > > Looks good, can be made a bit more robust. > > > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6 > > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff" > > It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that. Yeah, It may also be a good idea to not use QMake here. Let me re-think about this.
Note You need to log in before you can comment on or make changes to this bug.