Bug 101207

Summary: [Cairo] Make Cairo honor image orientation
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gustavo, gyuyoung.kim, kenneth, mrobinson, pnormand, rakuco, tmpsantos, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95299    
Attachments:
Description Flags
Patch
none
Patch, v2. Syntax fix for efl-wk1 TestExpectations.
none
Patch, v3, comment punctuation fixed.
none
Patch, v4, I mean, really. none

Dominik Röttsches (drott)
Reported 2012-11-05 03:56:46 PST
Analogously to bug 100179, Cairo needs to honor decoded image orientation info so that EXIF orientation is respected, see bug 100191.
Attachments
Patch (168.95 KB, patch)
2012-11-05 07:14 PST, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Patch, v2. Syntax fix for efl-wk1 TestExpectations. (168.99 KB, patch)
2012-11-05 07:25 PST, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Patch, v3, comment punctuation fixed. (168.99 KB, patch)
2012-11-05 07:28 PST, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Patch, v4, I mean, really. (169.06 KB, patch)
2012-11-05 07:38 PST, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-11-05 07:14:55 PST
Created attachment 172331 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-11-05 07:20:14 PST
Comment on attachment 172331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172331&action=review Nice! > Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:118 > + // ImageOrientation expects the origin to be at (0, 0) Punctuation mark at end
Dominik Röttsches (drott)
Comment 3 2012-11-05 07:25:58 PST
Created attachment 172332 [details] Patch, v2. Syntax fix for efl-wk1 TestExpectations.
Dominik Röttsches (drott)
Comment 4 2012-11-05 07:28:53 PST
Created attachment 172333 [details] Patch, v3, comment punctuation fixed.
Dominik Röttsches (drott)
Comment 5 2012-11-05 07:38:52 PST
Created attachment 172334 [details] Patch, v4, I mean, really.
WebKit Review Bot
Comment 6 2012-11-05 08:24:16 PST
Comment on attachment 172334 [details] Patch, v4, I mean, really. Clearing flags on attachment: 172334 Committed r133482: <http://trac.webkit.org/changeset/133482>
WebKit Review Bot
Comment 7 2012-11-05 08:24:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.