Bug 101207 - [Cairo] Make Cairo honor image orientation
Summary: [Cairo] Make Cairo honor image orientation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks: 95299
  Show dependency tree / graph
 
Reported: 2012-11-05 03:56 PST by Dominik Röttsches (drott)
Modified: 2012-11-05 08:24 PST (History)
10 users (show)

See Also:

Attachments
Patch (168.95 KB, patch)
2012-11-05 07:14 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch, v2. Syntax fix for efl-wk1 TestExpectations. (168.99 KB, patch)
2012-11-05 07:25 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch, v3, comment punctuation fixed. (168.99 KB, patch)
2012-11-05 07:28 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch, v4, I mean, really. (169.06 KB, patch)
2012-11-05 07:38 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-11-05 03:56:46 PST 
Analogously to bug 100179, Cairo needs to honor decoded image orientation info so that EXIF orientation is respected, see bug 100191.
Comment 1 Dominik Röttsches (drott) 2012-11-05 07:14:55 PST 
Created attachment 172331 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-05 07:20:14 PST 
Comment on attachment 172331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172331&action=review

Nice!

> Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:118
> +        // ImageOrientation expects the origin to be at (0, 0)

Punctuation mark at end
Comment 3 Dominik Röttsches (drott) 2012-11-05 07:25:58 PST 
Created attachment 172332 [details]
Patch, v2. Syntax fix for efl-wk1 TestExpectations.
Comment 4 Dominik Röttsches (drott) 2012-11-05 07:28:53 PST 
Created attachment 172333 [details]
Patch, v3, comment punctuation fixed.
Comment 5 Dominik Röttsches (drott) 2012-11-05 07:38:52 PST 
Created attachment 172334 [details]
Patch, v4, I mean, really.
Comment 6 WebKit Review Bot 2012-11-05 08:24:16 PST 
Comment on attachment 172334 [details]
Patch, v4, I mean, really.

Clearing flags on attachment: 172334

Committed r133482: <http://trac.webkit.org/changeset/133482>
Comment 7 WebKit Review Bot 2012-11-05 08:24:21 PST 
All reviewed patches have been landed.  Closing bug.