Bug 101205

Summary: [EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101057    
Attachments:
Description Flags
patch
none
patch none

Mikhail Pozdnyakov
Reported 2012-11-05 03:46:55 PST
Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects as part of bug101057 work.
Attachments
patch (27.89 KB, patch)
2012-11-05 03:51 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch (27.89 KB, patch)
2012-11-05 03:54 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-11-05 03:51:25 PST
Created attachment 172312 [details] patch
Mikhail Pozdnyakov
Comment 2 2012-11-05 03:54:30 PST
Created attachment 172313 [details] patch fixed '*' on wrong side.
Chris Dumez
Comment 3 2012-11-05 03:56:29 PST
Comment on attachment 172313 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60 > + EwkUrlRequest* request() const; We should probably make this getter non-const (although this can be done in a separate patch).
Mikhail Pozdnyakov
Comment 4 2012-11-05 03:59:15 PST
(In reply to comment #3) > (From update of attachment 172313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60 > > + EwkUrlRequest* request() const; > > We should probably make this getter non-const (although this can be done in a separate patch). We should make a big work to fix constness inside WK2 EFL, currently it's all very messy. Off course this is out if this patch's scope.
WebKit Review Bot
Comment 5 2012-11-05 04:39:30 PST
Comment on attachment 172313 [details] patch Clearing flags on attachment: 172313 Committed r133457: <http://trac.webkit.org/changeset/133457>
WebKit Review Bot
Comment 6 2012-11-05 04:39:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.