| Summary: | [EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
| Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 101057 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mikhail Pozdnyakov
2012-11-05 03:46:55 PST
Created attachment 172312 [details]
patch
Created attachment 172313 [details]
patch
fixed '*' on wrong side.
Comment on attachment 172313 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60 > + EwkUrlRequest* request() const; We should probably make this getter non-const (although this can be done in a separate patch). (In reply to comment #3) > (From update of attachment 172313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60 > > + EwkUrlRequest* request() const; > > We should probably make this getter non-const (although this can be done in a separate patch). We should make a big work to fix constness inside WK2 EFL, currently it's all very messy. Off course this is out if this patch's scope. Comment on attachment 172313 [details] patch Clearing flags on attachment: 172313 Committed r133457: <http://trac.webkit.org/changeset/133457> All reviewed patches have been landed. Closing bug. |