Bug 101204

Summary: Expose hit test related methods in public chromium port
Product: WebKit Reporter: Bo Liu <boliu>
Component: New BugsAssignee: Bo Liu <boliu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Add Changelog
none
Add comments. URLElement -> urlElement
none
Fix compile (also rename method in cpp file) none

Bo Liu
Reported 2012-11-05 03:37:02 PST
Expose hit test related methods in public chromium port
Attachments
Patch (4.56 KB, patch)
2012-11-05 03:41 PST, Bo Liu 		no flags
DetailsFormatted DiffDiff
Add Changelog (6.07 KB, patch)
2012-11-05 03:44 PST, Bo Liu 		no flags
DetailsFormatted DiffDiff
Add comments. URLElement -> urlElement (6.38 KB, patch)
2012-11-05 10:15 PST, Bo Liu 		no flags
DetailsFormatted DiffDiff
Fix compile (also rename method in cpp file) (6.38 KB, patch)
2012-11-05 10:21 PST, Bo Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Bo Liu
Comment 1 2012-11-05 03:41:45 PST
Created attachment 172306 [details] Patch
WebKit Review Bot
Comment 2 2012-11-05 03:44:00 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Bo Liu
Comment 3 2012-11-05 03:44:59 PST
Created attachment 172308 [details] Add Changelog
Adam Barth
Comment 4 2012-11-05 10:01:19 PST
Comment on attachment 172308 [details] Add Changelog View in context: https://bugs.webkit.org/attachment.cgi?id=172308&action=review > Source/WebKit/chromium/public/WebHitTestResult.h:67 > + WEBKIT_EXPORT WebElement URLElement() const; > + > + WEBKIT_EXPORT WebURL absoluteImageURL() const; > + > + WEBKIT_EXPORT WebURL absoluteLinkURL() const; > + > + WEBKIT_EXPORT bool isContentEditable() const; Please add comments explaining what this function do. Also URLElement is not in correct style. Perhaps urlElement?
Bo Liu
Comment 5 2012-11-05 10:15:21 PST
Created attachment 172355 [details] Add comments. URLElement -> urlElement
Adam Barth
Comment 6 2012-11-05 10:17:07 PST
Comment on attachment 172355 [details] Add comments. URLElement -> urlElement View in context: https://bugs.webkit.org/attachment.cgi?id=172355&action=review > Source/WebKit/chromium/src/WebHitTestResult.cpp:54 > +WebElement WebHitTestResult::URLElement() const Does this compile?
Bo Liu
Comment 7 2012-11-05 10:21:01 PST
Created attachment 172356 [details] Fix compile (also rename method in cpp file)
Bo Liu
Comment 8 2012-11-05 10:22:05 PST
(In reply to comment #6) > (From update of attachment 172355 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172355&action=review > > > Source/WebKit/chromium/src/WebHitTestResult.cpp:54 > > +WebElement WebHitTestResult::URLElement() const > > Does this compile? No of course not. Thanks for catching my mistake!! Also fyi, URLElement (uppercase URL) is in WebCore::HitTestResult
Adam Barth
Comment 9 2012-11-05 10:24:08 PST
> Also fyi, URLElement (uppercase URL) is in WebCore::HitTestResult If you're inclined, you might consider writing a follow-up patch to fix that. :)
WebKit Review Bot
Comment 10 2012-11-05 11:11:07 PST
Comment on attachment 172356 [details] Fix compile (also rename method in cpp file) Clearing flags on attachment: 172356 Committed r133503: <http://trac.webkit.org/changeset/133503>
WebKit Review Bot
Comment 11 2012-11-05 11:11:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.