Bug 101178

Summary: [Shadow] ShadowRoot should have a method to return ShadowRootType
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101170    
Attachments:
Description Flags
Patch none

Shinya Kawanaka
Reported 2012-11-04 21:37:51 PST
We would like to reject using pseudo id starting '-webkit-' in AuthorShadowRoot. However, we have to accept it in UA ShadowRoot. So we have to know ShadowRootType now.
Attachments
Patch (1.81 KB, patch)
2012-11-04 23:04 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-04 23:04:31 PST
Created attachment 172272 [details] Patch
Hajime Morrita
Comment 2 2012-11-04 23:15:40 PST
Comment on attachment 172272 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review > Source/WebCore/dom/ShadowRoot.h:119 > + ShadowRootType m_type : 1; Is it possible to ensure that ShadowRootType can be fit into a bit? Is STATIC_ASSERT or something helpful here?
Shinya Kawanaka
Comment 3 2012-11-04 23:22:20 PST
Comment on attachment 172272 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review >> Source/WebCore/dom/ShadowRoot.h:119 >> + ShadowRootType m_type : 1; > > Is it possible to ensure that ShadowRootType can be fit into a bit? > Is STATIC_ASSERT or something helpful here? I've tried adding extra enum item into ShadowRootType, then gcc complained that m_type field is too small. So I don't think we have to do something special here.
WebKit Review Bot
Comment 4 2012-11-04 23:30:22 PST
Comment on attachment 172272 [details] Patch Clearing flags on attachment: 172272 Committed r133435: <http://trac.webkit.org/changeset/133435>
WebKit Review Bot
Comment 5 2012-11-04 23:30:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.