Bug 101164

Summary: Web Inspector: render message bubbles in CodeMirror experiment.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] for landing none

Pavel Feldman
Reported 2012-11-04 02:27:49 PST
It sounds like addLineWidget just makes it happen.
Attachments
Patch (6.69 KB, patch)
2012-11-04 02:47 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] for landing (6.97 KB, patch)
2012-11-05 05:02 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-11-04 02:47:52 PST
Created attachment 172243 [details] Patch
Vsevolod Vlasov
Comment 2 2012-11-05 02:44:14 PST
Comment on attachment 172243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172243&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:65 > + this._widgets = []; Looks like this._widgets is redundant, you only use it to iterate over all widgets but this could be done using this._elementToWidget. > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:186 > + this._codeMirror.removeLineWidget(widget); Shouldn't we remove an entry from elementToWidget map as well here?
Pavel Feldman
Comment 3 2012-11-05 05:02:37 PST
Created attachment 172316 [details] [Patch] for landing
WebKit Review Bot
Comment 4 2012-11-05 05:43:37 PST
Comment on attachment 172316 [details] [Patch] for landing Clearing flags on attachment: 172316 Committed r133460: <http://trac.webkit.org/changeset/133460>
WebKit Review Bot
Comment 5 2012-11-05 05:43:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.