Bug 101111

Summary: [Mac] ResourceHandle changes for network process
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, jberlin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch jberlin: review+

Alexey Proskuryakov
Reported 2012-11-02 15:14:52 PDT
Patch forthcoming.
Attachments
proposed patch (9.27 KB, patch)
2012-11-02 15:27 PDT, Alexey Proskuryakov 		jberlin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-11-02 15:27:28 PDT
Created attachment 172159 [details] proposed patch
Jessie Berlin
Comment 2 2012-11-02 16:00:32 PDT
Comment on attachment 172159 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172159&action=review > Source/WebCore/ChangeLog:7 > + It would be good to give a short summary of why we want to use an NSOperationQueue here over scheduling with the run loop. > Source/WebCore/ChangeLog:11 > + Add an ability to schedul on an NSOperationQueue. Now that scheduling on run loop Typo: "schedul" > Source/WebCore/platform/network/NetworkingContext.h:27 > #include "SchedulePair.h" Nit pick: Don't we always put forward declarations after #includes?
Alexey Proskuryakov
Comment 3 2012-11-02 16:11:56 PDT
Committed <http://trac.webkit.org/changeset/133366>.
Alexey Proskuryakov
Comment 4 2012-11-05 15:13:05 PST
> Nit pick: Don't we always put forward declarations after #includes? I meant to change the header accordingly, but committed without saving this file. Will fix later.
Note You need to log in before you can comment on or make changes to this bug.