Bug 101091

Summary: EWS bots have stopped uploading results to bugzilla
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug abarth: review+

Eric Seidel (no email)
Reported 2012-11-02 12:57:33 PDT
EWS bots have stopped uploading results to bugzilla We may have disabled this intentionally, I can't remember. This should be the code: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py#L90 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L241 It may also be the size-cap code in bugzilla that we're hitting? There was an effort a while back to make the layout-test-results.zip files smaller. I suspect they're just too large for bugzilla to handle. Most of the time they should only be a few k! I suspect we'll need to use our LayoutTestResults object to whitelist which results we copy in to the zip.
Attachments
Fixes the bug (6.61 KB, patch)
2013-03-20 21:25 PDT, Ryosuke Niwa
abarth: review+
Ojan Vafai
Comment 1 2012-11-02 13:18:00 PDT
I think we never made the change to only copy unexpected failures into the zip. That's the key thing to making the zips small.
Dirk Pranke
Comment 2 2012-11-02 13:49:06 PDT
The EWS bots run with --skip-failing-tests, so they don't have the expected failures regardless.
Eric Seidel (no email)
Comment 3 2012-11-02 14:23:01 PDT
We already parse results.json and expose that via LayoutTestResults so we could easily build a white-listed copy function in python (and then either use it in NRWT or the EWS or both).
Ojan Vafai
Comment 4 2012-11-02 14:25:31 PDT
(In reply to comment #2) > The EWS bots run with --skip-failing-tests, so they don't have the expected failures regardless. Oh right. That should cover everything except flaky tests.
Dirk Pranke
Comment 5 2012-11-02 14:58:24 PDT
I expect there's a bunch of other less-than-useful stuff we could prune as well, like the tests_run* files and the web server logs.
Ryosuke Niwa
Comment 6 2013-03-20 21:25:36 PDT
Created attachment 194179 [details] Fixes the bug
Ryosuke Niwa
Comment 7 2013-03-21 00:32:45 PDT
Note You need to log in before you can comment on or make changes to this bug.