Bug 101083

Summary: [BlackBerry] Optimize backspace key handling
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-11-02 12:09:26 PDT
We can reduce the number of messages sent back and fourth on every backspace key by eliminating those going to the input_service.
Attachments
Patch (4.23 KB, patch)
2012-11-02 12:36 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (4.39 KB, patch)
2012-11-02 13:21 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-11-02 12:36:18 PDT
Created attachment 172111 [details] Patch
Yong Li
Comment 2 2012-11-02 13:06:52 PDT
Comment on attachment 172111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172111&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1494 > + if (m_receivedBackspaceKeyDown) > + m_receivedBackspaceKeyDown = false; the "if" is not needed in this case > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:229 > + bool m_receivedBackspaceKeyDown; initialize in the ctor?
Nima Ghanavatian
Comment 3 2012-11-02 13:21:43 PDT
Created attachment 172123 [details] Patch
WebKit Review Bot
Comment 4 2012-11-02 14:12:06 PDT
Comment on attachment 172123 [details] Patch Clearing flags on attachment: 172123 Committed r133343: <http://trac.webkit.org/changeset/133343>
WebKit Review Bot
Comment 5 2012-11-02 14:12:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.