Bug 101082

Summary: [BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
Product: WebKit Reporter: Lyon Chen <liachen>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: joenotcharles, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
patch for 101082 none

Description Lyon Chen 2012-11-02 12:05:36 PDT
In ResourceHandleBlackBerry, ResourceHandle::cancel() doesn't call setClient(0), which could leave a window that its client can still be called, after it is cancelled. This should be avoided.
Comment 1 Lyon Chen 2012-11-02 13:02:42 PDT
Created attachment 172120 [details]
patch for 101082
Comment 2 Lyon Chen 2012-11-02 13:03:42 PDT
+ Yong, Joe, Rob.
Comment 3 Yong Li 2012-11-02 13:31:30 PDT
Comment on attachment 172120 [details]
patch for 101082

I think it is good. ResourceLoader doesn't do this when it cancels the job:

        if (m_handle) {
            m_handle = 0;
Comment 4 WebKit Review Bot 2012-11-02 14:08:14 PDT
Comment on attachment 172120 [details]
patch for 101082

Clearing flags on attachment: 172120

Committed r133341: <http://trac.webkit.org/changeset/133341>
Comment 5 WebKit Review Bot 2012-11-02 14:08:18 PDT
All reviewed patches have been landed.  Closing bug.