Bug 101072

Summary: [GTK] Simplify GObject DOM bindings code for handling properties
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, haraken, japhet, webkit.review.bot, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 101074    
Attachments:
Description Flags
Patch
none
Updated patch including new test results xan.lopez: review+

Carlos Garcia Campos
Reported 2012-11-02 11:15:20 PDT
We can avoid some GObject boilerplate by not defining get/set_property methods when the object doesn't have properties, or writable properties.
Attachments
Patch (7.53 KB, patch)
2012-11-02 11:22 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch including new test results (38.72 KB, patch)
2012-11-02 12:08 PDT, Carlos Garcia Campos 		xan.lopez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-11-02 11:22:20 PDT
Created attachment 172091 [details] Patch
Carlos Garcia Campos
Comment 2 2012-11-02 12:08:06 PDT
Created attachment 172102 [details] Updated patch including new test results
Xan Lopez
Comment 3 2012-12-01 02:36:12 PST
Comment on attachment 172102 [details] Updated patch including new test results Yeah, looks great.
Carlos Garcia Campos
Comment 4 2012-12-04 01:43:10 PST
Committed r136491: <http://trac.webkit.org/changeset/136491>
Note You need to log in before you can comment on or make changes to this bug.