Summary: | BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, mifenton, morrita, peter+ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 101031 | ||||||||
Bug Blocks: | 100935 | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-11-02 03:25:15 PDT
Created attachment 172259 [details]
Patch
Comment on attachment 172259 [details] Patch Attachment 172259 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14731445 Created attachment 172262 [details]
Patch 2
Chromium-Android build fix
Comment on attachment 172262 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=172262&action=review > Source/WebCore/ChangeLog:15 > + elements. Is there any bug for this? Seems worth mentioning here. > Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp:44 > { Can we ASSERT() that this is attached()? Just for curious, what happens if a DOMActivate event is sent to the element through JS? Comment on attachment 172262 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=172262&action=review >> Source/WebCore/ChangeLog:15 >> + elements. > > Is there any bug for this? Seems worth mentioning here. will do. >> Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp:44 >> { > > Can we ASSERT() that this is attached()? > Just for curious, what happens if a DOMActivate event is sent to the element through JS? I don't think ASSERT(element()->attached()) is correct because, as you know, we can dispatch an event to a non-rendered element. In such case, the ScriptController::processingUserGesture() check below rejects opening a DateTimeChooser. Comment on attachment 172262 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=172262&action=review >>> Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp:44 >>> { >> >> Can we ASSERT() that this is attached()? >> Just for curious, what happens if a DOMActivate event is sent to the element through JS? > > I don't think ASSERT(element()->attached()) is correct because, as you know, we can dispatch an event to a non-rendered element. > In such case, the ScriptController::processingUserGesture() check below rejects opening a DateTimeChooser. OK, thanks for the explanation. Committed r133441: <http://trac.webkit.org/changeset/133441> |