Bug 101031

Summary: Add a common base class for date/time input types without inline editing behavior
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, haraken, mifenton, morrita, rakuco, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100935, 101038, 101039    
Attachments:
Description Flags
Patch morrita: review+

Kent Tamura
Reported 2012-11-02 02:22:13 PDT
Add a common base class for date/time input types without inline editing behavior
Attachments
Patch (18.21 KB, patch)
2012-11-02 02:27 PDT, Kent Tamura 		morrita: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-02 02:27:49 PDT
Created attachment 172013 [details] Patch
Hajime Morrita
Comment 2 2012-11-02 03:21:46 PDT
Comment on attachment 172013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172013&action=review > Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h:34 > +// FIXME: This class should implement DateTimeChooserClient. Let's mention the bug id here.
Kent Tamura
Comment 3 2012-11-02 03:29:41 PDT
(In reply to comment #2) > > +// FIXME: This class should implement DateTimeChooserClient. > > Let's mention the bug id here. Sure!
Kent Tamura
Comment 4 2012-11-02 03:30:06 PDT
Committed r133282: <http://trac.webkit.org/changeset/133282>
Note You need to log in before you can comment on or make changes to this bug.