Bug 101016

Summary: [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, enne, fishd, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description James Robinson 2012-11-01 22:50:18 PDT 
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Comment 1 James Robinson 2012-11-01 22:55:12 PDT 
Created attachment 171988 [details]
Patch
Comment 2 James Robinson 2012-11-01 22:56:52 PDT 
https://codereview.chromium.org/11312058 has to land before this.
Comment 3 WebKit Review Bot 2012-11-01 22:59:37 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Peter Beverloo (cr-android ews) 2012-11-01 23:05:49 PDT 
Comment on attachment 171988 [details]
Patch

Attachment 171988 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14663744
Comment 5 WebKit Review Bot 2012-11-02 01:41:11 PDT 
Comment on attachment 171988 [details]
Patch

Attachment 171988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14663781
Comment 6 Adrienne Walker 2012-11-02 09:42:21 PDT 
Comment on attachment 171988 [details]
Patch

R=me.
Comment 7 James Robinson 2012-11-05 10:02:56 PST 
Created attachment 172354 [details]
Patch
Comment 8 James Robinson 2012-11-05 12:49:22 PST 
Committed r133516: <http://trac.webkit.org/changeset/133516>
Comment 9 Eric Seidel (no email) 2013-01-04 00:51:36 PST 
Comment on attachment 172354 [details]
Patch

Cleared review? from attachment 172354 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).