Bug 101016 - [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Summary: [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 22:50 PDT by James Robinson
Modified: 2013-01-04 00:51 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2012-11-01 22:55 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2012-11-05 10:02 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-11-01 22:50:18 PDT 
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Comment 1 James Robinson 2012-11-01 22:55:12 PDT 
Created attachment 171988 [details]
Patch
Comment 2 James Robinson 2012-11-01 22:56:52 PDT 
https://codereview.chromium.org/11312058 has to land before this.
Comment 3 WebKit Review Bot 2012-11-01 22:59:37 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Peter Beverloo (cr-android ews) 2012-11-01 23:05:49 PDT 
Comment on attachment 171988 [details]
Patch

Attachment 171988 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14663744
Comment 5 WebKit Review Bot 2012-11-02 01:41:11 PDT 
Comment on attachment 171988 [details]
Patch

Attachment 171988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14663781
Comment 6 Adrienne Walker 2012-11-02 09:42:21 PDT 
Comment on attachment 171988 [details]
Patch

R=me.
Comment 7 James Robinson 2012-11-05 10:02:56 PST 
Created attachment 172354 [details]
Patch
Comment 8 James Robinson 2012-11-05 12:49:22 PST 
Committed r133516: <http://trac.webkit.org/changeset/133516>
Comment 9 Eric Seidel (no email) 2013-01-04 00:51:36 PST 
Comment on attachment 172354 [details]
Patch

Cleared review? from attachment 172354 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).