RESOLVED FIXED 101016
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas 
https://bugs.webkit.org/show_bug.cgi?id=101016
Summary [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
James Robinson
Reported 2012-11-01 22:50:18 PDT
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
Attachments
Patch (2.31 KB, patch)
2012-11-01 22:55 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2012-11-05 10:02 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-11-01 22:55:12 PDT
Created attachment 171988 [details] Patch
James Robinson
Comment 2 2012-11-01 22:56:52 PDT
https://codereview.chromium.org/11312058 has to land before this.
WebKit Review Bot
Comment 3 2012-11-01 22:59:37 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 4 2012-11-01 23:05:49 PDT
Comment on attachment 171988 [details] Patch Attachment 171988 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14663744
WebKit Review Bot
Comment 5 2012-11-02 01:41:11 PDT
Comment on attachment 171988 [details] Patch Attachment 171988 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14663781
Adrienne Walker
Comment 6 2012-11-02 09:42:21 PDT
Comment on attachment 171988 [details] Patch R=me.
James Robinson
Comment 7 2012-11-05 10:02:56 PST
Created attachment 172354 [details] Patch
James Robinson
Comment 8 2012-11-05 12:49:22 PST
Committed r133516: <http://trac.webkit.org/changeset/133516>
Eric Seidel (no email)
Comment 9 2013-01-04 00:51:36 PST
Comment on attachment 172354 [details] Patch Cleared review? from attachment 172354 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.