Bug 101008

Summary: https://bugs.webkit.org/show_bug.cgi?id=99647 broke the Windows build
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, fischman, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch fischman: review+

Description Roger Fong 2012-11-01 19:35:41 PDT
https://bugs.webkit.org/show_bug.cgi?id=99647 broke the Windows build.
Submitting a patch for build fix.
Comment 1 Roger Fong 2012-11-01 19:41:26 PDT
Created attachment 171977 [details]
patch
Comment 2 Ami Fischman 2012-11-01 19:44:28 PDT
Comment on attachment 171977 [details]
patch

LGTM (but I can't r+ since I'm not a WK reviewer).
Comment 3 Roger Fong 2012-11-01 19:54:28 PDT
Committed: http://trac.webkit.org/changeset/133262
Comment 4 Darin Adler 2012-11-02 15:56:13 PDT
Comment on attachment 171977 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171977&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3712
> +void HTMLMediaElement::clearMediaPlayer(signed flags)

We call this type int, not signed, in WebKit project source.
Comment 5 Roger Fong 2012-11-02 22:37:37 PDT
(In reply to comment #4)
> (From update of attachment 171977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171977&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:3712
> > +void HTMLMediaElement::clearMediaPlayer(signed flags)
> 
> We call this type int, not signed, in WebKit project source.

oops, will fix