Summary: | [Qt][Mac][Win] r133182 broke the build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nandor Huszka <hnandor> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Blocker | CC: | dongseong.hwang, gustavo, noam, ossy, philn, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 100907 | ||||||||||
Attachments: |
|
Description
Nandor Huszka
2012-11-01 15:19:31 PDT
Created attachment 171943 [details]
proposed patch
Comment on attachment 171943 [details] proposed patch Attachment 171943 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14686645 Created attachment 171947 [details]
proposed patch
Fix pure virtual problem.
Comment on attachment 171947 [details] proposed patch Attachment 171947 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14656691 Thanks for reporting and patch. Who broke build is me. I think we should not add this API in GraphicLayer. I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. virtual void setContentsScale(float) OVERRIDE; virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. void setContentsScale(float); void setVisibleContentRectTrajectoryVector(const FloatPoint&); I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. Could you do that? (In reply to comment #5) > Thanks for reporting and patch. Who broke build is me. > > I think we should not add this API in GraphicLayer. > > I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. > virtual void setContentsScale(float) OVERRIDE; > virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; > > How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. > void setContentsScale(float); > void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. > > Could you do that? Thank you for the tip, of course I will do that. Unfortunately I chose the wrong way of fixing first. Now I see that other platforms do not need these methods. Created attachment 172001 [details]
proposed patch
(In reply to comment #7) > Created an attachment (id=172001) [details] > proposed patch Thanks. LGTM! :) Comment on attachment 172001 [details] proposed patch Clearing flags on attachment: 172001 Committed r133276: <http://trac.webkit.org/changeset/133276> All reviewed patches have been landed. Closing bug. Comment on attachment 172001 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > + virtual void setContentsScale(float); > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! (In reply to comment #11) > (From update of attachment 172001 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > > + virtual void setContentsScale(float); > > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! Thanks. I filed Bug 101141. (In reply to comment #11) > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! I forgot to delete it too, thank you for the remark! |