| Summary: | [BlackBerry] Add a prompt to enable global location services | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | otcheung | ||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gtk-ews, gustavo, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
otcheung
2012-11-01 14:53:02 PDT
Created attachment 171939 [details]
Patch
Comment on attachment 171939 [details]
Patch
Looks good.
Comment on attachment 171939 [details] Patch Attachment 171939 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14665167 Comment on attachment 171939 [details] Patch Rejecting attachment 171939 [details] from commit-queue. otcheung@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 171939 [details] Patch Clearing flags on attachment: 171939 Committed r133247: <http://trac.webkit.org/changeset/133247> All reviewed patches have been landed. Closing bug. |