Bug 100990

Summary: Only resolve presentation attribute style once per shared ElementAttributeData.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 101198    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Cooler patch
koivisto: review+
Coolest(?) patch none

Andreas Kling
Reported 2012-11-01 14:42:29 PDT
We should exploit the fact that ElementAttributeData may be shared between multiple elements and only resolve presentation attribute style once per ElementAttributeData instead of once per Element.
Attachments
Patch (1.90 KB, patch)
2012-11-01 14:46 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Cooler patch (22.90 KB, patch)
2012-11-02 04:33 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Coolest(?) patch (8.45 KB, patch)
2012-11-14 12:57 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-11-01 14:46:59 PDT
Created attachment 171937 [details] Patch
Andreas Kling
Comment 2 2012-11-01 15:17:13 PDT
Comment on attachment 171937 [details] Patch Actually, we can do better than that.
Andreas Kling
Comment 3 2012-11-02 04:33:03 PDT
Created attachment 172033 [details] Cooler patch
Antti Koivisto
Comment 4 2012-11-02 04:39:01 PDT
Comment on attachment 172033 [details] Cooler patch View in context: https://bugs.webkit.org/attachment.cgi?id=172033&action=review r=me > Source/WebCore/dom/ElementAttributeData.h:101 > + void setStyleAttributeIsDirty(bool f) const { m_styleAttributeIsDirty = f; } > + bool presentationAttributeStyleIsDirty() const { return m_presentationAttributeStyleIsDirty; } > + void setPresentationAttributeStyleIsDirty(bool f) const { m_presentationAttributeStyleIsDirty = f; } f?! > Source/WebCore/dom/Node.h:714 > - // 2 bits remaining > + // 4 bits remaining Nice!
Andreas Kling
Comment 5 2012-11-02 04:53:26 PDT
(In reply to comment #4) > (From update of attachment 172033 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172033&action=review > > Source/WebCore/dom/ElementAttributeData.h:101 > > + void setStyleAttributeIsDirty(bool f) const { m_styleAttributeIsDirty = f; } > > + bool presentationAttributeStyleIsDirty() const { return m_presentationAttributeStyleIsDirty; } > > + void setPresentationAttributeStyleIsDirty(bool f) const { m_presentationAttributeStyleIsDirty = f; } > > f?! Yeah, I went there!
Andreas Kling
Comment 6 2012-11-02 05:11:10 PDT
Committed r133286: <http://trac.webkit.org/changeset/133286>
WebKit Review Bot
Comment 7 2012-11-05 02:15:39 PST
Re-opened since this is blocked by bug 101198
Andreas Kling
Comment 8 2012-11-14 12:57:17 PST
Created attachment 174233 [details] Coolest(?) patch Okay, let's try this again with a smaller scope: Just the presentation attribute style.
Antti Koivisto
Comment 9 2012-11-14 13:04:42 PST
Comment on attachment 174233 [details] Coolest(?) patch r=me
WebKit Review Bot
Comment 10 2012-11-14 13:58:46 PST
Comment on attachment 174233 [details] Coolest(?) patch Clearing flags on attachment: 174233 Committed r134664: <http://trac.webkit.org/changeset/134664>
WebKit Review Bot
Comment 11 2012-11-14 13:58:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.