Bug 100978

Summary: [BlackBerry] Add more form validation strings
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch yong.li.webkit: review+

Rob Buis
Reported 2012-11-01 12:32:18 PDT
SSIA
Attachments
Patch (3.94 KB, patch)
2012-11-01 14:13 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2012-11-01 14:15 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (3.98 KB, patch)
2012-11-01 14:53 PDT, Rob Buis 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-11-01 14:13:34 PDT
Created attachment 171926 [details] Patch
Rob Buis
Comment 2 2012-11-01 14:15:14 PDT
Created attachment 171928 [details] Patch
Rob Buis
Comment 3 2012-11-01 14:53:40 PDT
Created attachment 171938 [details] Patch
Yong Li
Comment 4 2012-11-01 14:55:13 PDT
Comment on attachment 171938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review > Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464 > + return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data()); it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s.
Yong Li
Comment 5 2012-11-01 14:55:28 PDT
(In reply to comment #4) > (From update of attachment 171938 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review > > > Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464 > > + return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data()); > > it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s. can be done in platform code.
Rob Buis
Comment 6 2012-11-01 15:00:15 PDT
Committed r133228: <http://trac.webkit.org/changeset/133228>
Note You need to log in before you can comment on or make changes to this bug.