Bug 100971

Summary: Add RGB to supported destination formats of ImageBuffer::copyToPlatformTexture
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, gman, junov, senorblanco, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 100714    
Bug Blocks: 100715    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2012-11-01 11:16:12 PDT
In https://bugs.webkit.org/show_bug.cgi?id=100714 , ImageBuffer::copyToPlatformTexture was restricted to only work with RGBA/UNSIGNED_BYTE textures. It turns out this is too restrictive; it's necessary to allow RGB textures as well to allow existing applications to work without performance regressions.
Attachments
Patch (3.11 KB, patch)
2012-11-01 11:20 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2012-11-01 11:20:50 PDT
Created attachment 171897 [details] Patch
Justin Novosad
Comment 2 2012-11-01 11:23:14 PDT
(In reply to comment #1) > Created an attachment (id=171897) [details] > Patch Does it resolve the problem described in comment 19 here: http://code.google.com/p/chromium/issues/detail?id=146219
Kenneth Russell
Comment 3 2012-11-01 11:23:44 PDT
Yes, I manually verified with his test case that the fast path is taken.
Stephen White
Comment 4 2012-11-01 11:24:42 PDT
Comment on attachment 171897 [details] Patch OK. r=me
WebKit Review Bot
Comment 5 2012-11-01 11:54:01 PDT
Comment on attachment 171897 [details] Patch Clearing flags on attachment: 171897 Committed r133202: <http://trac.webkit.org/changeset/133202>
WebKit Review Bot
Comment 6 2012-11-01 11:54:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.