Bug 100902

Summary: [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: gtk-ews, gustavo, mifenton, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch yong.li.webkit: review+, gtk-ews: commit-queue-

Rob Buis
Reported 2012-10-31 16:23:25 PDT
We can fix this test by just using the regular Page::findString like other ports do.
Attachments
Patch (11.62 KB, patch)
2012-10-31 16:32 PDT, Rob Buis 		yong.li.webkit: review+
gtk-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-10-31 16:32:32 PDT
Created attachment 171740 [details] Patch
kov's GTK+ EWS bot
Comment 2 2012-10-31 16:42:49 PDT
Comment on attachment 171740 [details] Patch Attachment 171740 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14670292
Yong Li
Comment 3 2012-10-31 17:28:45 PDT
Comment on attachment 171740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171740&action=review > Tools/ChangeLog:10 > + Fix the test my using the Page::findString method instead of our own in-page searcher. my => by?
Rob Buis
Comment 4 2012-11-01 07:42:24 PDT
Committed r133166: <http://trac.webkit.org/changeset/133166>
Note You need to log in before you can comment on or make changes to this bug.