Bug 100902 - [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
Summary: [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 16:23 PDT by Rob Buis
Modified: 2012-11-01 07:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.62 KB, patch)
2012-10-31 16:32 PDT, Rob Buis 		yong.li.webkit: review+
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-10-31 16:23:25 PDT 
We can fix this test by just using the regular Page::findString like other ports do.
Comment 1 Rob Buis 2012-10-31 16:32:32 PDT 
Created attachment 171740 [details]
Patch
Comment 2 kov's GTK+ EWS bot 2012-10-31 16:42:49 PDT 
Comment on attachment 171740 [details]
Patch

Attachment 171740 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14670292
Comment 3 Yong Li 2012-10-31 17:28:45 PDT 
Comment on attachment 171740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171740&action=review

> Tools/ChangeLog:10
> +        Fix the test my using the Page::findString method instead of our own in-page searcher.

my => by?
Comment 4 Rob Buis 2012-11-01 07:42:24 PDT 
Committed r133166: <http://trac.webkit.org/changeset/133166>