Bug 100848

Summary: [EFL] Platform support for Accessibility feature.
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Krzysztof Czech <k.czech>
Status: RESOLVED FIXED    
Severity: Normal CC: apinheiro, benjamin, cfleizach, dmazzoni, d-r, g.czajkowski, gyuyoung.kim, jdiggs, laszlo.gombos, lucas.de.marchi, m.leszko, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on: 99578    
Bug Blocks: 98895, 100757, 103036    
Attachments:
Description Flags
[EFL] Platform support for Accessibility feature.
eflews.bot: commit-queue-
[EFL] Platform support for Accessibility feature. none

Krzysztof Czech
Reported 2012-10-31 06:20:32 PDT
Define ACCESSIBILITY macro. Support for ATK library.
Attachments
[EFL] Platform support for Accessibility feature. (10.27 KB, patch)
2012-11-07 05:40 PST, Krzysztof Czech 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
[EFL] Platform support for Accessibility feature. (10.27 KB, patch)
2012-11-22 02:39 PST, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2012-11-07 05:40:12 PST
Created attachment 172772 [details] [EFL] Platform support for Accessibility feature.
EFL EWS Bot
Comment 2 2012-11-07 05:56:25 PST
Comment on attachment 172772 [details] [EFL] Platform support for Accessibility feature. Attachment 172772 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14755467
Krzysztof Czech
Comment 3 2012-11-07 06:00:44 PST
This patch enables support for Accessibility feature in WebCore. In general, core Accessibility implementation will be shared with gtk see: https://bugs.webkit.org/show_bug.cgi?id=99578 Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes.
Krzysztof Czech
Comment 4 2012-11-07 06:15:07 PST
*** Bug 99156 has been marked as a duplicate of this bug. ***
Krzysztof Czech
Comment 5 2012-11-12 07:40:24 PST
EFL bot is red because of the dependency problem. It should wait for (99578). > Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes. I thought about a flag that enables Accessibility for EFL. Implementing this, I had some compilation errors because of the missing HAVE_ACCESSIBILITY macro in some places. As soon as this patch lands in mainstream, I propose fix for this problem.
Grzegorz Czajkowski
Comment 6 2012-11-20 07:56:18 PST
(In reply to comment #5) > EFL bot is red because of the dependency problem. It should wait for (99578). bug 99578 landed, at the moment we shouldn't have any compilation issues. > > Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes. > > I thought about a flag that enables Accessibility for EFL. Implementing this, I had some compilation errors because of the missing HAVE_ACCESSIBILITY macro in some places. As soon as this patch lands in mainstream, I propose fix for this problem. I am in favor of features that can be manipulated during compilation, especially if they require dependency like atk etc. Actually, in this way we implemented spelling for WK2-EFL. If you are going to add possibility to turn off accessibility feature for WK-EFL please open separate bug and set proper dependency as this patch blocks another bug (bug 100757).
Krzysztof Czech
Comment 7 2012-11-22 01:31:14 PST
I created new bug for turning off accessibility for WebKit-EFL. https://bugs.webkit.org/show_bug.cgi?id=103036
Gyuyoung Kim
Comment 8 2012-11-22 02:23:46 PST
I installed libatk1.0-dev to efl ews. Please re-submit.
Krzysztof Czech
Comment 9 2012-11-22 02:39:10 PST
Created attachment 175633 [details] [EFL] Platform support for Accessibility feature.
Grzegorz Czajkowski
Comment 10 2012-11-22 02:50:37 PST
(In reply to comment #8) > I installed libatk1.0-dev to efl ews. Dominik, could you install it on Intel bots too? Thanks.
Grzegorz Czajkowski
Comment 11 2012-11-22 06:58:32 PST
LGTM.
Gyuyoung Kim
Comment 12 2012-11-23 00:00:28 PST
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. Is there any unskip test cases by this patch ?
Krzysztof Czech
Comment 13 2012-11-23 00:39:33 PST
(In reply to comment #12) > (From update of attachment 175633 [details]) > Is there any unskip test cases by this patch ? All the accessibility tests cases are skipped at the moment. There's a bug (100757) that adds some platform specific changes to WTR. I think as soon those 2 patches will land it. We can try to unskip some accessibility tests.
Gyuyoung Kim
Comment 14 2012-11-23 00:55:02 PST
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. View in context: https://bugs.webkit.org/attachment.cgi?id=175633&action=review > Source/cmake/OptionsEfl.cmake:194 > + As laszlo pointed out, please add ENABLE_ACCESSIBILITY to here soon.
Gyuyoung Kim
Comment 15 2012-11-23 00:56:07 PST
Beside you need to add libatk1.0-dev to dependencies in http://trac.webkit.org/wiki/EFLWebKit
Krzysztof Czech
Comment 16 2012-11-23 01:03:35 PST
(In reply to comment #14) > (From update of attachment 175633 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175633&action=review > > > Source/cmake/OptionsEfl.cmake:194 > > + > > As laszlo pointed out, please add ENABLE_ACCESSIBILITY to here soon. I already opened a ticket for it (103036). I will do this very soon.Thanks.
WebKit Review Bot
Comment 17 2012-11-23 01:22:56 PST
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. Clearing flags on attachment: 175633 Committed r135569: <http://trac.webkit.org/changeset/135569>
WebKit Review Bot
Comment 18 2012-11-23 01:23:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.