Bug 100846
| Summary: | [JSC] Web Inspector: support Debugger.pause for dedicated workers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | apavlov, ap, bfulgham, graouts, joepeck, keishi, loislo, mark.lam, PeterHWang, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit-bug-importer, yurys |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Yury Semikhatsky
Pause command should worker for dedicated workers in JSC.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Peter Wang
So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
Are there some special cases have to be considered? Please give some tips, thank you very much.
Yury Semikhatsky
(In reply to comment #1)
> So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
>
> Are there some special cases have to be considered? Please give some tips, thank you very much.
The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
Peter Wang
(In reply to comment #2)
> (In reply to comment #1)
> > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
> >
> > Are there some special cases have to be considered? Please give some tips, thank you very much.
>
> The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
>
> There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
Ok, I'll check it and report the newest situation here. Thank you.
Peter Wang
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
> > >
> > > Are there some special cases have to be considered? Please give some tips, thank you very much.
> >
> > The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
> >
> > There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
>
> Ok, I'll check it and report the newest situation here. Thank you.
My local Qt build (r135111) can pass this case.
Brent Fulgham
This test appears to be working. Please reopen if you find that there is still an issue with this test.
Alexey Proskuryakov
The test is skipped on Mac, which is why the flakiness dashboard doesn't see it fail.
Radar WebKit Bug Importer
<rdar://problem/19049362>
Joseph Pecoraro
*** This bug has been marked as a duplicate of bug 164136 ***