Bug 100800

Summary: webkitpy: refactor common command line arguments for --platform, rebaseline commands
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ojan: review+

Dirk Pranke
Reported 2012-10-30 17:36:05 PDT
webkitpy: refactor common command line arguments for --platform, rebaseline commands
Attachments
Patch (14.98 KB, patch)
2012-10-30 17:37 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-10-30 17:37:07 PDT
Created attachment 171557 [details] Patch
Ojan Vafai
Comment 2 2012-10-30 20:49:44 PDT
Comment on attachment 171557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171557&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:63 > + move_overwritten_baselines_option = optparse.make_option("--move-overwritten-baselines", action="store_true", default=False, This is unused? > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70 > + platform_options = factory.platform_options() This is unused?
Dirk Pranke
Comment 3 2012-10-30 21:20:47 PDT
Comment on attachment 171557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171557&action=review >> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70 >> + platform_options = factory.platform_options() > > This is unused? Yeah, these are both used in the next patch (for garden-o-matic and its called commands). I'll delete them for now.
Ojan Vafai
Comment 4 2012-10-30 21:49:59 PDT
Comment on attachment 171557 [details] Patch r=me with the unused bits deleted
Dirk Pranke
Comment 5 2012-10-31 11:32:31 PDT
Committed r133051: <http://trac.webkit.org/changeset/133051>
Note You need to log in before you can comment on or make changes to this bug.