Bug 100760

Summary: [BlackBerry] Update BB10 form theme.
Product: WebKit Reporter: Tiancheng Jiang <tijiang>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, glenn, jonathan.dong.webkit, macpherson, menard, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
webkit patch
rwlbuis: review-
webkit patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tiancheng Jiang
Reported 2012-10-30 07:35:33 PDT
Upadte checkbox, radio, textfield, button, dropdown and range slider to meet cascade ux spec.
Attachments
webkit patch (35.95 KB, patch)
2012-10-30 08:12 PDT, Tiancheng Jiang 		rwlbuis: review-
DetailsFormatted DiffDiff
webkit patch (36.91 KB, patch)
2012-10-30 12:20 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (35.60 KB, patch)
2012-10-30 15:46 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2012-11-01 08:35 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2012-11-01 08:44 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2012-11-01 09:23 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (7.46 KB, patch)
2012-11-06 07:56 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2012-11-06 08:07 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2012-11-06 13:40 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2012-11-07 13:50 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2012-11-11 11:42 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (9.54 KB, patch)
2012-11-11 11:57 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2012-11-12 13:32 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2012-11-14 18:01 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2012-11-28 12:07 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (4.00 KB, patch)
2012-11-29 07:54 PST, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2013-05-24 15:48 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2013-05-28 13:40 PDT, Tiancheng Jiang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.
Tiancheng Jiang
Comment 1 2012-10-30 08:12:33 PDT
Created attachment 171454 [details] webkit patch Introduce slice function to update form theme.
Rob Buis
Comment 2 2012-10-30 08:38:45 PDT
Comment on attachment 171454 [details] webkit patch View in context: https://bugs.webkit.org/attachment.cgi?id=171454&action=review Don't forget that you need a ChangeLog! If you do one mention PR and internal reviewer. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:74 > +// Slider Aura, caculated from UX spec Typo caculated. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:77 > +// Dropdown arrow position, caculated from UX spec Ditto. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:478 > + if (!disabled || !background || !inactive || !pressed || !active || !activeMark || !disableMark) You probably want to log something if this failed. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:486 > + float centerY = (float(inactive->height()) - float(activeMark->height())) / 2 / float(inactive->height()) * tmpRect.height() + tmpRect.y(); the double '/' looks weird, please try to add more parentheses. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:541 > + float centerY = (float(inactive->height()) - float(activeMark->height())) / 2 / float(inactive->height()) * tmpRect.height() + tmpRect.y(); Ditto.
Tiancheng Jiang
Comment 3 2012-10-30 12:20:31 PDT
Created attachment 171497 [details] webkit patch
Rob Buis
Comment 4 2012-10-30 12:30:57 PDT
Comment on attachment 171497 [details] webkit patch LGTM.
WebKit Review Bot
Comment 5 2012-10-30 13:32:36 PDT
Comment on attachment 171497 [details] webkit patch Rejecting attachment 171497 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: succeeded at 514 (offset -14 lines). Hunk #11 succeeded at 570 (offset -14 lines). Hunk #12 succeeded at 618 (offset -14 lines). Hunk #13 succeeded at 625 (offset -14 lines). Hunk #14 succeeded at 716 (offset -14 lines). patching file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h Hunk #1 succeeded at 105 (offset -5 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14620947
Tiancheng Jiang
Comment 6 2012-10-30 15:46:25 PDT
Created attachment 171540 [details] Patch
Rob Buis
Comment 7 2012-10-30 15:47:50 PDT
Comment on attachment 171540 [details] Patch LGTM.
WebKit Review Bot
Comment 8 2012-10-30 17:13:05 PDT
Comment on attachment 171540 [details] Patch Clearing flags on attachment: 171540 Committed r132967: <http://trac.webkit.org/changeset/132967>
WebKit Review Bot
Comment 9 2012-10-30 17:13:10 PDT
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 10 2012-11-01 08:35:01 PDT
Reopening to attach new patch.
Tiancheng Jiang
Comment 11 2012-11-01 08:35:04 PDT
Created attachment 171858 [details] Patch
Rob Buis
Comment 12 2012-11-01 08:37:28 PDT
Comment on attachment 171858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171858&action=review > Source/WebCore/ChangeLog:3 > + Check img pointer is null, if so, do early return. Bug title should go here. > Source/WebCore/ChangeLog:9 > + Fix description should go here.
Tiancheng Jiang
Comment 13 2012-11-01 08:44:47 PDT
Created attachment 171861 [details] Patch
Tiancheng Jiang
Comment 14 2012-11-01 09:23:10 PDT
Created attachment 171872 [details] Patch
Rob Buis
Comment 15 2012-11-01 09:26:08 PDT
Comment on attachment 171872 [details] Patch LGTM.
WebKit Review Bot
Comment 16 2012-11-01 09:46:35 PDT
Comment on attachment 171872 [details] Patch Clearing flags on attachment: 171872 Committed r133186: <http://trac.webkit.org/changeset/133186>
WebKit Review Bot
Comment 17 2012-11-01 09:46:39 PDT
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 18 2012-11-06 07:56:47 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 19 2012-11-06 07:56:49 PST
Created attachment 172589 [details] Patch
Tiancheng Jiang
Comment 20 2012-11-06 08:07:10 PST
Created attachment 172591 [details] Patch
Rob Buis
Comment 21 2012-11-06 08:08:55 PST
Comment on attachment 172591 [details] Patch Ok.
WebKit Review Bot
Comment 22 2012-11-06 10:18:02 PST
Comment on attachment 172591 [details] Patch Clearing flags on attachment: 172591 Committed r133632: <http://trac.webkit.org/changeset/133632>
WebKit Review Bot
Comment 23 2012-11-06 10:18:07 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 24 2012-11-06 13:40:21 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 25 2012-11-06 13:40:24 PST
Created attachment 172640 [details] Patch
Rob Buis
Comment 26 2012-11-06 13:41:54 PST
Comment on attachment 172640 [details] Patch Ok.
WebKit Review Bot
Comment 27 2012-11-06 14:50:58 PST
Comment on attachment 172640 [details] Patch Clearing flags on attachment: 172640 Committed r133674: <http://trac.webkit.org/changeset/133674>
WebKit Review Bot
Comment 28 2012-11-06 14:51:03 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 29 2012-11-07 13:49:58 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 30 2012-11-07 13:50:10 PST
Created attachment 172865 [details] Patch
Rob Buis
Comment 31 2012-11-07 14:03:06 PST
Comment on attachment 172865 [details] Patch LGTM.
WebKit Review Bot
Comment 32 2012-11-07 14:48:51 PST
Comment on attachment 172865 [details] Patch Clearing flags on attachment: 172865 Committed r133808: <http://trac.webkit.org/changeset/133808>
WebKit Review Bot
Comment 33 2012-11-07 14:48:56 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 34 2012-11-11 11:42:04 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 35 2012-11-11 11:42:07 PST
Created attachment 173511 [details] Patch
Tiancheng Jiang
Comment 36 2012-11-11 11:57:10 PST
Created attachment 173513 [details] Patch
Rob Buis
Comment 37 2012-11-11 12:35:12 PST
Comment on attachment 173513 [details] Patch The ChangeLog looks a bit strange but will hopefully work...
WebKit Review Bot
Comment 38 2012-11-11 12:37:32 PST
Comment on attachment 173513 [details] Patch Rejecting attachment 173513 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ILED at 739. Hunk #5 succeeded at 973 (offset -14 lines). Hunk #6 succeeded at 1007 (offset -14 lines). Hunk #7 succeeded at 1031 (offset -14 lines). 2 out of 7 hunks FAILED -- saving rejects to file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp.rej patching file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14689539
Rob Buis
Comment 39 2012-11-12 07:00:44 PST
Comment on attachment 173511 [details] Patch LGTM.
WebKit Review Bot
Comment 40 2012-11-12 07:20:43 PST
Comment on attachment 173511 [details] Patch Clearing flags on attachment: 173511 Committed r134227: <http://trac.webkit.org/changeset/134227>
WebKit Review Bot
Comment 41 2012-11-12 07:44:24 PST
Comment on attachment 173513 [details] Patch Clearing flags on attachment: 173513 Committed r134240: <http://trac.webkit.org/changeset/134240>
WebKit Review Bot
Comment 42 2012-11-12 07:44:29 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 43 2012-11-12 13:32:08 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 44 2012-11-12 13:32:13 PST
Created attachment 173708 [details] Patch
Rob Buis
Comment 45 2012-11-12 13:34:34 PST
Comment on attachment 173708 [details] Patch Ok.
WebKit Review Bot
Comment 46 2012-11-12 18:29:29 PST
Comment on attachment 173708 [details] Patch Clearing flags on attachment: 173708 Committed r134338: <http://trac.webkit.org/changeset/134338>
WebKit Review Bot
Comment 47 2012-11-12 18:29:34 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 48 2012-11-14 18:01:23 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 49 2012-11-14 18:01:27 PST
Created attachment 174305 [details] Patch
Rob Buis
Comment 50 2012-11-14 18:44:41 PST
Comment on attachment 174305 [details] Patch Ok.
WebKit Review Bot
Comment 51 2012-11-14 18:59:54 PST
Comment on attachment 174305 [details] Patch Clearing flags on attachment: 174305 Committed r134724: <http://trac.webkit.org/changeset/134724>
WebKit Review Bot
Comment 52 2012-11-14 19:00:01 PST
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 53 2012-11-28 12:07:30 PST
Reopening to attach new patch.
Tiancheng Jiang
Comment 54 2012-11-28 12:07:34 PST
Created attachment 176538 [details] Patch
Tiancheng Jiang
Comment 55 2012-11-29 07:54:53 PST
Created attachment 176738 [details] Patch
Rob Buis
Comment 56 2012-11-29 08:55:14 PST
Comment on attachment 176738 [details] Patch LGTM.
WebKit Review Bot
Comment 57 2012-11-29 09:10:47 PST
Comment on attachment 176738 [details] Patch Clearing flags on attachment: 176738 Committed r136136: <http://trac.webkit.org/changeset/136136>
WebKit Review Bot
Comment 58 2012-11-29 09:10:54 PST
All reviewed patches have been landed. Closing bug.
Jeff Rogers
Comment 59 2013-05-21 19:05:27 PDT
*** Bug 101924 has been marked as a duplicate of this bug. ***
Rob Buis
Comment 60 2013-05-23 20:40:50 PDT
Comment on attachment 176738 [details] Patch Ok.
Tiancheng Jiang
Comment 61 2013-05-24 15:48:21 PDT
Reopening to attach new patch.
Tiancheng Jiang
Comment 62 2013-05-24 15:48:26 PDT
Created attachment 202858 [details] Patch
Rob Buis
Comment 63 2013-05-27 07:40:42 PDT
Comment on attachment 202858 [details] Patch Ok.
WebKit Commit Bot
Comment 64 2013-05-27 08:02:50 PDT
Comment on attachment 202858 [details] Patch Clearing flags on attachment: 202858 Committed r150754: <http://trac.webkit.org/changeset/150754>
WebKit Commit Bot
Comment 65 2013-05-27 08:02:56 PDT
All reviewed patches have been landed. Closing bug.
Tiancheng Jiang
Comment 66 2013-05-28 13:40:28 PDT
Reopening to attach new patch.
Tiancheng Jiang
Comment 67 2013-05-28 13:40:33 PDT
Created attachment 203083 [details] Patch
Rob Buis
Comment 68 2013-05-29 10:19:22 PDT
Comment on attachment 203083 [details] Patch LGTM.
WebKit Commit Bot
Comment 69 2013-05-29 10:41:07 PDT
Comment on attachment 203083 [details] Patch Clearing flags on attachment: 203083 Committed r150908: <http://trac.webkit.org/changeset/150908>
WebKit Commit Bot
Comment 70 2013-05-29 10:41:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.