| Summary: | [EFL][GTK] Adapt accessibility feature to WebKitTestRunner. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mateusz Leszko <m.leszko> |
| Component: | WebKit EFL | Assignee: | Mateusz Leszko <m.leszko> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | apinheiro, g.czajkowski, gyuyoung.kim, k.czech, laszlo.gombos, lucas.de.marchi, mario, mrobinson, rakuco, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 99011, 100848 | ||
| Bug Blocks: | 98895 | ||
| Attachments: | |||
|
Description
Mateusz Leszko
2012-10-30 06:59:02 PDT
Created attachment 174430 [details]
Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency.
Test are failing due to 99011 dependency. Comment on attachment 174430 [details]
Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency.
Clearing the review flag as the patch couldn't be applied to the trunk. Please rebase the patch.
Created attachment 175177 [details]
Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency.
rebase
Comment on attachment 175177 [details] Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency. Attachment 175177 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14934220 Comment on attachment 175177 [details] Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency. View in context: https://bugs.webkit.org/attachment.cgi?id=175177&action=review > LayoutTests/ChangeLog:3 > + [EFL][GTK] Adapt accessibility support for EFL. It seems that the patch allows to compile accessibility feature for WTR to pass accessibility tests. Wouldn't be better to change the title to: [EFL] Adapt accessibility feature to WebKitTestRunner. ? IMHO this patch doesn't touch WebKit-GTK at all, so we can omit [GTK] prefix. > Tools/ChangeLog:8 > + Adding macros specified for EFL accessibility. Sounds unclear, What about "Allow to build accessibility feature in WebkitTestRunner for EFL Platform." ? > Tools/ChangeLog:9 > + Updating CMake files. Please describe what you are changing in CMake configurations, like adding atk includes etc. > Tools/ChangeLog:10 > + Removed gtk/gtk.h dependency. Please add this note in below list next to method where the dependency is being removed. Patch is not building due to Bug 100848 dependency. Comment on attachment 175177 [details] Adding macros specified for EFL accessibility. Updating CMake files. Removed gtk/gtk.h dependency. View in context: https://bugs.webkit.org/attachment.cgi?id=175177&action=review >> LayoutTests/ChangeLog:3 >> + [EFL][GTK] Adapt accessibility support for EFL. > > It seems that the patch allows to compile accessibility feature for WTR to pass accessibility tests. Wouldn't be better to change the title to: > [EFL] Adapt accessibility feature to WebKitTestRunner. ? > IMHO this patch doesn't touch WebKit-GTK at all, so we can omit [GTK] prefix. Changing title. Leaving [GTK] tag due to removing "include <gtk/gtk.h>". >> Tools/ChangeLog:8 >> + Adding macros specified for EFL accessibility. > > Sounds unclear, What about "Allow to build accessibility feature in WebkitTestRunner for EFL Platform." ? Sounds good. >> Tools/ChangeLog:9 >> + Updating CMake files. > > Please describe what you are changing in CMake configurations, like adding atk includes etc. ok >> Tools/ChangeLog:10 >> + Removed gtk/gtk.h dependency. > > Please add this note in below list next to method where the dependency is being removed. ok Created attachment 175210 [details]
Adapt accessibility feature to WebKitTestRunner.
Comment on attachment 175210 [details] Adapt accessibility feature to WebKitTestRunner. Attachment 175210 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14911638 Thanks for the changes. LGTM. Let's wait for bug 100848 to meet dependency. Created attachment 175752 [details]
Adapt accessibility feature to WebKitTestRunner.
CC'ing reviewers. All dependences solved. Local review done. Comment on attachment 175752 [details]
Adapt accessibility feature to WebKitTestRunner.
r=me.
Comment on attachment 175752 [details] Adapt accessibility feature to WebKitTestRunner. Clearing flags on attachment: 175752 Committed r135619: <http://trac.webkit.org/changeset/135619> All reviewed patches have been landed. Closing bug. Created attachment 175816 [details]
[EFL] Skipping Accessibility tests for wk2.
Created attachment 175818 [details]
[EFL] Skipping Accessibility tests for wk1/wk2.
Created attachment 175820 [details]
[EFL] Adapt accessibility feature to WebKitTestRunner.
Comment on attachment 175820 [details]
[EFL] Adapt accessibility feature to WebKitTestRunner.
r=me.
updating patch due to skipping test. Comment on attachment 175820 [details] [EFL] Adapt accessibility feature to WebKitTestRunner. Clearing flags on attachment: 175820 Committed r135627: <http://trac.webkit.org/changeset/135627> All reviewed patches have been landed. Closing bug. |