Bug 100755

Summary: [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, gyuyoung.kim, kenneth, lucas.de.marchi, ojan, ossy, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100810    
Attachments:
Description Flags
patch none

Kangil Han
Reported 2012-10-30 06:48:47 PDT
Currently, WK1 is not considered on layout test in baseline search path.
Attachments
patch (1.48 KB, patch)
2012-10-30 06:50 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-10-30 06:50:51 PDT
Created attachment 171439 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-10-30 07:25:10 PDT
Comment on attachment 171439 [details] patch Looks OK.
WebKit Review Bot
Comment 3 2012-10-30 08:40:20 PDT
Comment on attachment 171439 [details] patch Clearing flags on attachment: 171439 Committed r132910: <http://trac.webkit.org/changeset/132910>
WebKit Review Bot
Comment 4 2012-10-30 08:40:24 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2012-10-30 10:44:48 PDT
It broke a python unit test: File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl") AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl' Could you update the test?
Kangil Han
Comment 6 2012-10-30 20:59:39 PDT
(In reply to comment #5) > It broke a python unit test: > > File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory > self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl") > AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl' > > Could you update the test? Oops.. I will figure out what has happened.
Note You need to log in before you can comment on or make changes to this bug.