Bug 100746

Summary: [EFL] combine color profile failures to the correct bug
Product: WebKit Reporter: Jussi Kukkonen (jku) <jussi.kukkonen>
Component: Tools / TestsAssignee: Jussi Kukkonen (jku) <jussi.kukkonen>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. none

Jussi Kukkonen (jku)
Reported 2012-10-30 04:44:56 PDT
TestExpectations gardening, patch coming.
Attachments
Patch (2.47 KB, patch)
2012-10-30 04:50 PDT, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. (2.47 KB, patch)
2012-10-30 06:43 PDT, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1 2012-10-30 04:50:05 PDT
Created attachment 171421 [details] Patch
Jussi Kukkonen (jku)
Comment 2 2012-10-30 05:00:06 PDT
Comment on attachment 171421 [details] Patch forgot to add "cq?"
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-10-30 06:08:54 PDT
Comment on attachment 171421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171421&action=review > LayoutTests/platform/efl/TestExpectations:659 > +# EFL does not USE(QCMSLIB) so color transforms are not done Wouldn't it make sense to make this comment more generic? I understood that this is something we're not really interested in fixing and not that it doesn't work because we do not use that lib.
Jussi Kukkonen (jku)
Comment 4 2012-10-30 06:43:54 PDT
Created attachment 171436 [details] I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'.
WebKit Review Bot
Comment 5 2012-10-30 07:14:19 PDT
Comment on attachment 171436 [details] I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. Clearing flags on attachment: 171436 Committed r132908: <http://trac.webkit.org/changeset/132908>
WebKit Review Bot
Comment 6 2012-10-30 07:14:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.