Bug 100744

Summary: [BlackBerry] PurgeCredential should also purge the persisted credential store
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: joenotcharles, jonathan.dong.webkit, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Charles Wei
Reported 2012-10-30 03:59:13 PDT
NetworkJob::purgeCredentials() purges the credential from the memory that fails the authentication, which means that the credential is incorrect (it could be that it is incorrect from the beginning, or that it was correct but the credential was changed on server, could be through another device, etc.) and should not be used again. We should also purge the credential record in the persistent credential storage (the CredentialBackingStore). Otherwise, the browser will read from the persistent credential storage and send the invalid credential again when challenged.
Attachments
Patch (1.95 KB, patch)
2012-10-30 04:06 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2012-10-30 18:40 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-10-30 04:06:21 PDT
Created attachment 171415 [details] Patch
Charles Wei
Comment 2 2012-10-30 04:13:34 PDT
Internal tracking No: 233482
WebKit Review Bot
Comment 3 2012-10-30 05:14:34 PDT
Comment on attachment 171415 [details] Patch Rejecting attachment 171415 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Source/WebKit/chromium/third_party/skia/include --revision 6161 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 6161. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14629506
Charles Wei
Comment 4 2012-10-30 18:40:18 PDT
Created attachment 171562 [details] Patch
Charles Wei
Comment 5 2012-10-30 18:41:00 PDT
Comment on attachment 171562 [details] Patch Reviewed by George. Commit it.
WebKit Review Bot
Comment 6 2012-10-30 19:02:22 PDT
Comment on attachment 171562 [details] Patch Clearing flags on attachment: 171562 Committed r132976: <http://trac.webkit.org/changeset/132976>
WebKit Review Bot
Comment 7 2012-10-30 19:02:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.