Bug 100742 – [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Emil A Eklund]

As we no longer pixel snap values when computing the current width for a line we shouldn't do it in shrinkAvailableWidthForNewFloatIfNeeded either.

[Emil A Eklund]

Created attachment 171414 [details]
Patch

[Emil A Eklund]

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=156971

[Eric Seidel (no email)]

Comment on attachment 171414 [details]
Patch

OK.

[Emil A Eklund]

Created attachment 171416 [details]
Patch

[Levi Weintraub]

Comment on attachment 171416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171416&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-103
> -#else
> -    bool fitsOnLine() const { return currentWidth() <= m_availableWidth; }
> -    bool fitsOnLine(float extra) const { return currentWidth() + extra <= m_availableWidth; }
> -#endif

Good catch.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:175
> -        float newLeft = m_block->pixelSnappedLogicalRightForFloat(newFloat);
> +        float newLeft = m_block->logicalRightForFloat(newFloat);

Good to see more of these pixel snappings becoming unnecessary.

[Levi Weintraub]

(In reply to comment #3)
> (From update of attachment 171414 [details])
> OK.

Eseidel doesn't sleep, he waits.

[WebKit Review Bot]

Comment on attachment 171416 [details]
Patch

Clearing flags on attachment: 171416

Committed r132904: <http://trac.webkit.org/changeset/132904>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.