Bug 100739

Summary: [CSS] Expand -webkit-line-break value space
Product: WebKit Reporter: Glenn Adams <glenn>
Component: CSSAssignee: Glenn Adams <glenn>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cmarcelo, eric, macpherson, menard, mitz, seikwon.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89235    
Attachments:
Description Flags
Patch none

Description Glenn Adams 2012-10-30 03:42:53 PDT
(1) expand -webkit-line-break to include new values defined by CSS3 Text [1], i.e., 'auto', 'strict', 'loose';
(2) change default (initial) value for -webkit-line-break to 'auto' to match CSS3 Text;
(3) rename enum EKHTMLLineBreak to LineBreak, renaming enum values appropriately;

this bug is a sub-division of bug 89235, and prepares the way for committing a patch thereto

[1] http://dev.w3.org/csswg/css3-text/#line-break
Comment 1 Glenn Adams 2012-10-30 04:29:46 PDT
Created attachment 171418 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-30 11:00:32 PDT
Comment on attachment 171418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171418&action=review

> Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74
> -    , khtmlLineBreak(LBNORMAL)
> +    , lineBreak(LineBreakAuto)

Do we need to change the code which depends on this value?  Is our linebreaking still correct?
Comment 3 Glenn Adams 2012-10-30 12:49:08 PDT
(In reply to comment #2)
> (From update of attachment 171418 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171418&action=review
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74
> > -    , khtmlLineBreak(LBNORMAL)
> > +    , lineBreak(LineBreakAuto)
> 
> Do we need to change the code which depends on this value?  Is our linebreaking still correct?

No change needed. There is actually no code that explicitly refers to LBNORMAL (now LineBreakAuto). I believe we're safe to c+ this.
Comment 4 Eric Seidel (no email) 2012-10-30 12:56:57 PDT
Comment on attachment 171418 [details]
Patch

OK.  THanks.  I really appreciate you breaking this up, it makes it easier to handle the reviews.  Please feel encouraged to CC me on future patches.
Comment 5 WebKit Review Bot 2012-10-30 13:31:29 PDT
Comment on attachment 171418 [details]
Patch

Clearing flags on attachment: 171418

Committed r132942: <http://trac.webkit.org/changeset/132942>
Comment 6 WebKit Review Bot 2012-10-30 13:31:33 PDT
All reviewed patches have been landed.  Closing bug.