Bug 100724

Summary: [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
Product: WebKit Reporter: Peter Wang <PeterHWang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, gyuyoung.kim, kpiascik, leoyang, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Peter Wang
Reported 2012-10-29 20:39:27 PDT
Just open this bug to clean the code of "JavaScriptDebuggerBlackBerry".
Attachments
Patch (17.15 KB, patch)
2012-10-29 21:04 PDT, Peter Wang 		no flags
DetailsFormatted DiffDiff
Patch (17.10 KB, patch)
2012-10-30 18:43 PDT, Peter Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Wang
Comment 1 2012-10-29 21:04:24 PDT
Created attachment 171367 [details] Patch
Konrad Piascik
Comment 2 2012-10-30 06:48:11 PDT
The patch looks fine to me, I'd just like a better commit message. We're not cleaning up the code but removing it entirely.
Rob Buis
Comment 3 2012-10-30 06:53:22 PDT
Comment on attachment 171367 [details] Patch Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title.
Peter Wang
Comment 4 2012-10-30 18:17:40 PDT
(In reply to comment #3) > (From update of attachment 171367 [details]) > Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title. Ok, thank you very much
Peter Wang
Comment 5 2012-10-30 18:43:22 PDT
Created attachment 171563 [details] Patch
Peter Wang
Comment 6 2012-10-30 18:59:49 PDT
Comment on attachment 171563 [details] Patch reviewed by Rob, new path is for correct ChangeLog
WebKit Review Bot
Comment 7 2012-10-30 19:00:15 PDT
Comment on attachment 171563 [details] Patch Rejecting attachment 171563 [details] from review queue. peter.wang@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Peter Wang
Comment 8 2012-10-30 19:00:57 PDT
Comment on attachment 171563 [details] Patch reviewed by Rob, new path is for correct ChangeLog
WebKit Review Bot
Comment 9 2012-10-30 19:50:49 PDT
Comment on attachment 171563 [details] Patch Clearing flags on attachment: 171563 Committed r132978: <http://trac.webkit.org/changeset/132978>
WebKit Review Bot
Comment 10 2012-10-30 19:50:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.