| Summary: | [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Wang <PeterHWang> | ||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | charles.wei, gyuyoung.kim, kpiascik, leoyang, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Wang
2012-10-29 20:39:27 PDT
Created attachment 171367 [details]
Patch
The patch looks fine to me, I'd just like a better commit message. We're not cleaning up the code but removing it entirely. Comment on attachment 171367 [details]
Patch
Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title.
(In reply to comment #3) > (From update of attachment 171367 [details]) > Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title. Ok, thank you very much Created attachment 171563 [details]
Patch
Comment on attachment 171563 [details]
Patch
reviewed by Rob, new path is for correct ChangeLog
Comment on attachment 171563 [details] Patch Rejecting attachment 171563 [details] from review queue. peter.wang@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 171563 [details]
Patch
reviewed by Rob, new path is for correct ChangeLog
Comment on attachment 171563 [details] Patch Clearing flags on attachment: 171563 Committed r132978: <http://trac.webkit.org/changeset/132978> All reviewed patches have been landed. Closing bug. |