Bug 100720 – Build WebKit as C++11 on Mac

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Build WebKit as C++11 on Mac

[Anders Carlsson]

Created attachment 171359 [details]
Patch

[Daniel Bates]

Comment on attachment 171359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171359&action=review

> Source/WTF/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please remove these sentences.

> Source/WTF/wtf/text/AtomicString.cpp:270
> +    UCharBuffer buffer = { s, static_cast<unsigned>(length) };

Would it make sense to change the static type of length from int to unsigned in this function since, as its name implies, it's a length (so it should be non-negative)? Then we don't need to explicitly cast it to unsigned here.

> Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp:467
> +    FormContext formContext = { formData.release(), static_cast<unsigned long long>(length) };

Would it make sense to change the static type of length from long long to unsigned long long in this function since, as its name implies, it's a length (so it should be non-negative)? Then we don't need to explicitly cast it to unsigned long long here.

> Tools/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please remove these sentences.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 171359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171359&action=review
> 
> > Source/WTF/wtf/text/AtomicString.cpp:270
> > +    UCharBuffer buffer = { s, static_cast<unsigned>(length) };
> 
> Would it make sense to change the static type of length from int to unsigned in this function since, as its name implies, it's a length (so it should be non-negative)? Then we don't need to explicitly cast it to unsigned here.

Yes, it makes sense to do so.

> 
> > Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp:467
> > +    FormContext formContext = { formData.release(), static_cast<unsigned long long>(length) };
> 
> Would it make sense to change the static type of length from long long to unsigned long long in this function since, as its name implies, it's a length (so it should be non-negative)? Then we don't need to explicitly cast it to unsigned long long here.

Ditto.

Thanks for reviewing!

[Anders Carlsson]

Committed r132925: <http://trac.webkit.org/changeset/132925>