Bug 100703

Summary: Coordinated Graphics: support the "freeze animations" API
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dongseong.hwang, jturcotte, kbalazs, kenneth, rafael.lobo, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Noam Rosenthal
Reported 2012-10-29 15:02:40 PDT
Right now we can't reliably test pixels of animations, because freeze is not implemented. We need to support freeze in coordinated graphics by sending a timestamp when CoordinatedGraphicsLayer::suspendAnimations is called and respect it in LayerTreeRenderer.
Attachments
Patch (7.80 KB, patch)
2012-11-15 06:55 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2012-11-16 08:06 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2012-11-13 06:20:41 PST
I'll drop this for now, but here's some bugs that might point to the right direction: 100673, 100769, 27627, 43792, 43733.
Balazs Kelemen
Comment 2 2012-11-14 01:30:28 PST
I can go for it.
Balazs Kelemen
Comment 3 2012-11-15 06:55:53 PST
Created attachment 174425 [details] Patch
Balazs Kelemen
Comment 4 2012-11-15 07:27:51 PST
Comment on attachment 174425 [details] Patch Clearing flags on attachment: 174425 Committed r134772: <http://trac.webkit.org/changeset/134772>
Balazs Kelemen
Comment 5 2012-11-15 07:27:55 PST
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 6 2012-11-16 03:21:33 PST
After this patch, jank appears in most of all animations. For example, falling leaves. http://www.webkit.org/blog-files/leaves/index.html
Balazs Kelemen
Comment 7 2012-11-16 03:52:31 PST
(In reply to comment #6) > After this patch, jank appears in most of all animations. > > For example, falling leaves. http://www.webkit.org/blog-files/leaves/index.html Tanks, I will look into this.
Balazs Kelemen
Comment 8 2012-11-16 08:03:37 PST
Err, I was just missing to initialize the new members, and it did not cause problem in DRT and I did not check the browser.
Balazs Kelemen
Comment 9 2012-11-16 08:06:36 PST
Created attachment 174685 [details] Patch
Balazs Kelemen
Comment 10 2012-11-16 08:13:07 PST
Comment on attachment 174685 [details] Patch Clearing flags on attachment: 174685 Committed r134952: <http://trac.webkit.org/changeset/134952>
Balazs Kelemen
Comment 11 2012-11-16 08:13:12 PST
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 12 2012-11-18 15:00:05 PST
Thanks for fixing it!
Note You need to log in before you can comment on or make changes to this bug.